modules: Amend hashicorp filtering #1607
Conversation
The go VER line was there, but not in the beginning as it should. Signed-off-by: Or Shoval <[email protected]>
According cncf/foundation#617 (comment) we need to look on go.mod only because we have "go 1.17" in go.mod. Adapt git actions accordingly. Signed-off-by: Or Shoval <[email protected]>
kubevirt-bot
added
release-note-none
|
Kudos, SonarCloud Quality Gate passed!
|
|
/cc @dhiller |
|
/lgtm |
|
@qinqon: Overrode contexts on behalf of qinqon: pull-e2e-cnao-multus-dynamic-networks-functests In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
What this PR does / why we need it:
According [1] we need to look on go.mod only because we have "go 1.17" in go.mod.
Adapt git actions accordingly.
Special notes for your reviewer:
All the 3 modules whitelisted on this PR are approved by GB exception, example [2]
More reading about it [3]
[1] cncf/foundation#617 (comment)
[2] https://github.com/cncf/foundation/blob/e8bd39f52b9b577a0ba2fcb2bfa8e68b35ebc1e8/license-exceptions/cncf-exceptions-2022-04-12.json#L80
[3] cncf/foundation#617 (comment)
Release note: