Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dependency in prom-rules-verify make target #1878

Merged

Conversation

nestoracunablanco
Copy link
Contributor

This target needs that the necessary tooling is available beforehand.

What this PR does / why we need it: makefile minor fixes

Special notes for your reviewer:

Release note:


@kubevirt-bot kubevirt-bot added release-note-none Denotes a PR that doesn't merit a release note. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. labels Aug 30, 2024
@kubevirt-bot
Copy link
Collaborator

Hi @nestoracunablanco. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nestoracunablanco
Copy link
Contributor Author

@RamLavi @phoracek What are your thoughts on this change? Do you require any additional modifications or clarifications?

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 9, 2024

/ok-to-test

@nestoracunablanco
Copy link
Contributor Author

/test all

@kubevirt-bot
Copy link
Collaborator

@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@nestoracunablanco
Copy link
Contributor Author

Hi @RamLavi, It seems that I'm unable to trigger the tests. Could someone else please trigger them?

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 10, 2024

/ok-to-test

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 10, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@nestoracunablanco
Copy link
Contributor Author

/test all

@kubevirt-bot
Copy link
Collaborator

@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/test all

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 10, 2024

/ok-to-test

@nestoracunablanco can you rebase? it would probably solve the IPAM lane issue

This target needs that the necessary tooling is available
beforehand.

Signed-off-by: Nestor Acuna Blanco <[email protected]>
@kubevirt-bot kubevirt-bot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
Copy link

sonarcloud bot commented Sep 10, 2024

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 10, 2024

/lgtm

@kubevirt-bot kubevirt-bot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2024
@nestoracunablanco
Copy link
Contributor Author

/retest

@kubevirt-bot
Copy link
Collaborator

@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 11, 2024

@nestoracunablanco looks like a metrics-relevant test failed on the kubemacpool tier1 lane.

E2E Test Suite: [It] [rfe_id:3503][crit:medium][vendor:[email protected]][level:component]Virtual Machines Check the client When all the VMs are serviced by default (opt-out mode) and creating two VMs with same mac, one on unmanaged (opted out) namespace should detect duplicate macs gauge after restarting kubemacpool, and then mitigating that

Can you take a look to see if it's related?

@nestoracunablanco
Copy link
Contributor Author

@RamLavi, I ran the kubemacpool functional tests on my workstation, and they were successful.

Since the change pertains only to the verification of the Prometheus rules and is related to the build process (with no code modifications that could impact runtime), I do not see a connection between this change and the error.

@nestoracunablanco
Copy link
Contributor Author

@RamLavi, based on the information I provided, do you have any issues with rerunning the pull-e2e-cluster-network-addons-operator-kubemacpool-functests?

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 16, 2024

/test pull-e2e-cluster-network-addons-operator-kubemacpool-functests

@nestoracunablanco
Copy link
Contributor Author

@RamLavi, all tests are successful now. Is there anything else needed for approval?

@RamLavi
Copy link
Collaborator

RamLavi commented Sep 16, 2024

/approve

@kubevirt-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: RamLavi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubevirt-bot kubevirt-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 16, 2024
@RamLavi
Copy link
Collaborator

RamLavi commented Sep 17, 2024

/retest
seems unrelated. will open an issue separately

@kubevirt-bot kubevirt-bot merged commit 8cd74a6 into kubevirt:main Sep 17, 2024
16 checks passed
@nestoracunablanco nestoracunablanco deleted the fix/prom-rules-verify-deps branch September 17, 2024 07:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates the PR's author has DCO signed all their commits. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants