-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: dependency in prom-rules-verify make target #1878
fix: dependency in prom-rules-verify make target #1878
Conversation
Hi @nestoracunablanco. Thanks for your PR. PRs from untrusted users cannot be marked as trusted with I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
/test all |
@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Hi @RamLavi, It seems that I'm unable to trigger the tests. Could someone else please trigger them? |
/ok-to-test |
/lgtm |
/test all |
@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test @nestoracunablanco can you rebase? it would probably solve the IPAM lane issue |
This target needs that the necessary tooling is available beforehand. Signed-off-by: Nestor Acuna Blanco <[email protected]>
6b8bc41
to
b5b08bf
Compare
Quality Gate passedIssues Measures |
/lgtm |
/retest |
@nestoracunablanco: Cannot trigger testing until a trusted user reviews the PR and leaves an In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@nestoracunablanco looks like a metrics-relevant test failed on the kubemacpool tier1 lane.
Can you take a look to see if it's related? |
@RamLavi, I ran the kubemacpool functional tests on my workstation, and they were successful. Since the change pertains only to the verification of the Prometheus rules and is related to the build process (with no code modifications that could impact runtime), I do not see a connection between this change and the error. |
@RamLavi, based on the information I provided, do you have any issues with rerunning the pull-e2e-cluster-network-addons-operator-kubemacpool-functests? |
/test pull-e2e-cluster-network-addons-operator-kubemacpool-functests |
@RamLavi, all tests are successful now. Is there anything else needed for approval? |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
This target needs that the necessary tooling is available beforehand.
What this PR does / why we need it: makefile minor fixes
Special notes for your reviewer:
Release note: