tools/bumper: Fix latest vtag check #1888
Conversation
kubevirt-bot
added
release-note-none
|
backporting to all supported stable branches. |
|
@RamLavi: once the present PR merges, I will cherry-pick it on top of release-0.95 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
RamLavi
force-pushed
the
fix_vtag_logic
branch
2 times, most recently
from
e9e5197
to
3d77f69
Compare
In the bumper logic, in case either currentReleaseVersion or latestReleaseVersion are in virtual-tag format (i.e. v0.44.1-1-g4cd33665) - then the bump should be initiated. However the logic implementing it is wrong. Fixing logic, adding unit tests. Signed-off-by: Ram Lavi <[email protected]>
RamLavi
force-pushed
the
fix_vtag_logic
branch
from
3d77f69
to
9e6abcf
Compare
|
|
/test pull-e2e-cluster-network-addons-operator-br-marker-functests |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qinqon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
Ignoring the Sonar cloud issue. Duplicate lines in DescribeTable Entries are OK by design. |
|
@RamLavi: new pull request created: #1889 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@RamLavi: new pull request created: #1890 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.93 |
|
@RamLavi: new pull request created: #1891 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@RamLavi: new pull request could not be created: failed to create pull request against kubevirt/cluster-network-addons-operator#release-0.93 from head kubevirt-bot:cherry-pick-1888-to-release-0.93: status code 422 not one of [201], body: {"message":"Validation Failed","errors":[{"resource":"PullRequest","code":"custom","message":"A pull request already exists for kubevirt-bot:cherry-pick-1888-to-release-0.93."}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#create-a-pull-request","status":"422"} In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.89 |
|
@RamLavi: new pull request created: #1892 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/cherry-pick release-0.95 |
|
@RamLavi: new pull request created: #1897 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What this PR does / why we need it:
In the bumper logic, in case either currentReleaseVersion or latestReleaseVersion are in virtual-tag format (i.e. v0.44.1-1-g4cd33665) - then the bump should be initiated. However the logic implementing it is wrong.
Fixing logic, adding unit tests.
Special notes for your reviewer:
Release note: