[release-0.95] tools/bumper: Allow general vtag format. #1899
Conversation
The bumper currently assumes that virtual tags consists of eight sha characters after the "g" (for example: v0.39.0-32-g12345678). This is not the default configuration (which is seven). As this number of sha characters is configurable, changing the regex in isVtagFormat to accept any number of character (bigger than four which is what 'git describe --abbrev=X' accepts) as a valid vtag format. Also, fixing unit tests to use character aligned to the default and adding more to check the above logic. Signed-off-by: Ram Lavi <[email protected]>
kubevirt-bot
added
release-note-none
|
|
/test pull-e2e-cnao-multus-dynamic-networks-functests-release-0.95 /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: RamLavi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubevirt-bot
added
the
approved
|
@kubevirt-bot: The following test failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
This is an automated cherry-pick of #1898
/assign RamLavi