deploy, kustomize: provide an OpenShift overlay #21
Conversation
Signed-off-by: Miguel Duarte Barroso <[email protected]>
| - op: add | ||
| path: /metadata/annotations | ||
| value: | ||
| service.beta.openshift.io/serving-cert-secret-name: webhook-service |
There was a problem hiding this comment.
need to figure out the name of the service here ... the prefix above (line 9) is not playing along here.
maybe consider removing the prefix ?...
There was a problem hiding this comment.
ye no need the prefix imo
fwiw note please that CNAO will know to do it all itself based only on dist/install.yaml
so this PR is needed only if you want to be able to deploy the repo standalone on OCP
i would even suggest the minimalist manifest kustomize if so for this
even seds or easiest possible
no need naming / namespace changes
There was a problem hiding this comment.
Ah thanks. I had forgotten about that.
Well, it still makes sense, but, the priority surely drops quite a lot.
It would still be useful to test drive the feature early on OpenShift though.
There was a problem hiding this comment.
changing manually only the required bit, the secret need to be "kubevirt-ipam-claims-webhook-service"
maybe you can set it as such for both U/S and D/S
without prefixing stuff (or at least not the secret) and it will work ?
(adapting to kubevirt-ipam-controller-webhook-service once time comes)
|
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with /lifecycle stale |
kubevirt-bot
added
the
lifecycle/stale
Provide an overlay for OpenShift.