Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

set min reclaim pool size for multi region #761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yadzhang
Copy link
Collaborator

What type of PR is this?

fix

What this PR does / why we need it:

set min reclaimed pool size to 8 in multi share region scene

Which issue(s) this PR fixes:

to fix machine hung for the priority inversion problem caused by a sudden drop in reclaim pool size.

Special notes for your reviewer:

@yadzhang yadzhang added the workflow/draft draft: no need to review label Jan 13, 2025
@yadzhang yadzhang requested a review from gary-lgy as a code owner January 13, 2025 10:16
@yadzhang yadzhang force-pushed the feat/min-reclaim-poolsize branch from 888c8c9 to b2df8d4 Compare January 13, 2025 10:19
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 14.28571% with 18 lines in your changes missing coverage. Please review.

Project coverage is 56.85%. Comparing base (f3d81a4) to head (2cbbb55).

Files with missing lines Patch % Lines
...u/assembler/provisionassembler/assembler_common.go 14.28% 16 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #761      +/-   ##
==========================================
+ Coverage   56.83%   56.85%   +0.02%     
==========================================
  Files         606      606              
  Lines       69941    69962      +21     
==========================================
+ Hits        39748    39776      +28     
- Misses      25927    25934       +7     
+ Partials     4266     4252      -14     
Flag Coverage Δ
unittest 56.85% <14.28%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yadzhang yadzhang force-pushed the feat/min-reclaim-poolsize branch from b2df8d4 to 23eb7fd Compare January 13, 2025 12:56
@yadzhang yadzhang force-pushed the feat/min-reclaim-poolsize branch from 23eb7fd to 2cbbb55 Compare January 13, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
workflow/draft draft: no need to review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant