Add lock and unlock gocat Slack commands #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enables the integration of slackcmd and deploy.Coordinator into the SlackListener, so that it can try to lock/unlock projects and environments when it sees /lock and /unlock respectively.
mumoshu
changed the title
pirlodog1125
approved these changes
Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the gocat Slack commands
@bot lockand@bot unlockon top of #1123.You can see a number of commits for refactoring, fixes, and CI improvements, but the gist of this PR are:
SlackListenerwho handles any@bot commandto additionally support@bot lockand@bot unlock.slack_test.gofor testing the gocat Slack bot's behavior, using a fake Slack API, a fake GitHub API, and a preconfigured Kubernetes cluster likekind.What's NOT included
There might be a plenty of potential improvements we can make further:
project X environment ' has already been locked by user1 for REASONlock failed due to permission error: consult anyone with Developer role to lock it.But those are out of the scope of this PR!