New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include who-locked-it in `describe locks` response #1136

Merged

pirlodog1125 merged 2 commits into kufu-ai:master from mumoshu:who-locked

Sep 5, 2024

Contributor

mumoshu commented Sep 5, 2024

I made two changes on top of #1134 to let describe locks responses include who locked deployments:

f8a5362: Uses Slack username instead of user ID as the identifier of who-locked-this. Usernames are more human-readable than IDs.
8360b34: Surfaces the Slack usernames persisted in who-locked-this configmap to descibe locks responses.

mumoshu added 2 commits

September 5, 2024 01:47


          Use Slack display name instead of user ID for locking

f8a5362


          Include who locked it in describe-locks response

8360b34

mumoshu changed the title ~~Who locked~~ Include who-locked-it in describe locks response

pirlodog1125 approved these changes

View reviewed changes

pirlodog1125 merged commit 6b313c9 into kufu-ai:master

5 checks passed

mumoshu deleted the who-locked branch

September 5, 2024 11:02

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet