Add CONFIG_NAMESPACE and CONFIG_LOCKS_CONFIGMAP_NAME #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add two environment variables to specify the namespace and the confimap to use lock-related features. The namespace has been `gocat` but we no longer have the default. You need to explicitly specify the namespace, using the downward API, for example. Similarly, the configmap name has been `deploylocks`, but we have no default value anymore. Specify it, like CONFIG_LOCKS_CONFIGMAP_NAME=deploylocks, for example to retain the default behavior.
pirlodog1125
approved these changes
Sep 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add two environment variables to specify the namespace and the confimap to use lock-related features.
The namespace has been
gocatbut we no longer have the default. You need to explicitly specify the namespace, using the downward API, for example.Similarly, the configmap name has been
deploylocks, but we have no default value anymore. Specify it, like CONFIG_LOCKS_CONFIGMAP_NAME=deploylocks, for example to retain the default behavior.