Fix describe locks bug #1156
Merged
Fix describe locks bug #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pirlodog1125
approved these changes
Nov 11, 2024
pirlodog1125
force-pushed
the
fix-describe-locks-bug
branch
from
c781096
to
5c29e37
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reveals and fixes the known bug in
describe lockswhere it treats "myproject-api/prod" as "myproject/api" indescribe locksoutput.The first commit 272632a refactors the lock manager so that the lock, unlock, and describe locks against the encoded form of the locks info(=configmap data), can be tested without a K8s fake client or a K8s cluster. It also add unit tests and reveals the bug 272632a#diff-58fdb8b585fff39180c0d3e7e736adeccc351c620058e9d921d54704ace96d3cR61-R65.
The second commit c781096 fixes the bug and the test.
Related to #1155