Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💬: デフォルト値が入力できるコンポーネントを列挙し、並び替え #1239

Closed
wants to merge 1 commit into from
Closed

💬: デフォルト値が入力できるコンポーネントを列挙し、並び替え #1239

wants to merge 1 commit into from

Conversation

uknmr
Copy link
Collaborator

@uknmr uknmr commented Jun 28, 2024

入力系コンポーネントはすべからくデフォルト値を持てるので修正してみた。

@uknmr uknmr requested review from versionfive, tosiiu and a team as code owners June 28, 2024 10:57
@uknmr uknmr requested review from oti and MasafumiKabe June 28, 2024 10:57
@netlify Netlify
Copy link

netlify bot commented Jun 28, 2024 •
edited
Loading

✅ Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit 38012cd
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/667e9713d1f6b000089322a5
😎 Deploy Preview https://deploy-preview-1239--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@versionfive versionfive requested a review from oremega July 1, 2024 02:02
oremega
oremega reviewed Jul 1, 2024
View reviewed changes
Copy link
Contributor

@oremega oremega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

リンク追加ありがとうございます。
これ自体は問題ないと思います。

ただ、コンポーネント側からのデフォルト値へのリンクも追加したいです。
このPRじゃなくてもいいとは思っています。

入力系（DatePicker、MultiComboBox、SingleComboBox、Textarea）
スクリーンショット 2024-07-01 13 13 53

チェック系（RadioButtonPanel）
スクリーンショット 2024-07-01 13 23 34

versionfive
versionfive reviewed Jul 3, 2024
View reviewed changes
Copy link
Contributor

@versionfive versionfive left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

310さんのコメント対応待ち

@uknmr uknmr closed this Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@versionfive versionfive versionfive left review comments

@oremega oremega oremega left review comments

@tosiiu tosiiu Awaiting requested review from tosiiu tosiiu is a code owner

@oti oti Awaiting requested review from oti oti is a code owner automatically assigned from kufu/products-designsystem-reviewer

@MasafumiKabe MasafumiKabe Awaiting requested review from MasafumiKabe MasafumiKabe is a code owner automatically assigned from kufu/products-designsystem-reviewer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uknmr @oremega @versionfive