-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ライティング>UIテキスト>エラーメッセージの内容をFlashMessageからNotificationBarに変更 #1485
base: main
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for smarthr-design-system ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kuvanov-2 1点だけ、本題じゃないところなのですが気になったので🙏
* バックグラウンド処理画面 | ||
* FlashMessage | ||
ここでは、以下の場合について説明します。 | ||
* バックグラウンド処理画面 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
バックグラウンド処理画面のほうにはリンク貼りませんか?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@INABAshina はってみました! 7db9293
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
課題・背景
ライティング>UIテキスト>エラーメッセージの内容が、非推奨のFlashMessageを扱っていたため、NotificationBarに変更した
https://smarthr.atlassian.net/browse/SD-860
やったこと
記述の微調整
動作確認