Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ライティング>UIテキスト>エラーメッセージの内容をFlashMessageからNotificationBarに変更 #1485

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

kuvanov-2
Copy link
Contributor

課題・背景

ライティング>UIテキスト>エラーメッセージの内容が、非推奨のFlashMessageを扱っていたため、NotificationBarに変更した

https://smarthr.atlassian.net/browse/SD-860

やったこと

記述の微調整

動作確認

  • ファイルでの確認で十分だよ。

Copy link

netlify bot commented Jan 7, 2025

Deploy Preview for smarthr-design-system ready!

Name Link
🔨 Latest commit 27eb476
🔍 Latest deploy log https://app.netlify.com/sites/smarthr-design-system/deploys/67888c5e12ab530008252a3a
😎 Deploy Preview https://deploy-preview-1485--smarthr-design-system.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@kuvanov-2 kuvanov-2 requested a review from keroyama-nao January 7, 2025 11:03
Copy link
Contributor

@INABAshina INABAshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kuvanov-2 1点だけ、本題じゃないところなのですが気になったので🙏

* バックグラウンド処理画面
* FlashMessage
ここでは、以下の場合について説明します。
* バックグラウンド処理画面
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

バックグラウンド処理画面のほうにはリンク貼りませんか?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@INABAshina はってみました! 7db9293

@keroyama-nao keroyama-nao removed their request for review January 16, 2025 00:46
Copy link
Contributor

@INABAshina INABAshina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants