chore: InputFileの内部処理をリファクタリングする #5283
Open
+47
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yagimushi
force-pushed
the
chore-refactoring-InputFile
branch
from
b5503a0 to
635feb2
Compare
commit: |
AtsushiM
changed the title
AtsushiM
commented
Jan 15, 2025
Comment on lines
+155
to
+160
| (e: React.MouseEvent<HTMLButtonElement>) => { | ||
| if (!inputRef.current) { | ||
| return | ||
| } | ||
|
|
||
| const index = parseInt(e.currentTarget.value, 10) |
There was a problem hiding this comment.
button要素のvalueを参照するように変更することで、handleDeleteが再作成される可能性を激減させました。
ほぼ再作成されなくなると思われます
AtsushiM
commented
Jan 15, 2025
Comment on lines
+218
to
+228
| const StyledFaFolderOpenIcon = React.memo<{ className: string }>(({ className }) => ( | ||
| <span className={className}> | ||
| <FaFolderOpenIcon /> | ||
| </span> | ||
| )) | ||
|
|
||
| const LabelRender = React.memo<{ id: string; label: ReactNode }>(({ id, label }) => ( | ||
| <span id={id} aria-hidden="true"> | ||
| {label} | ||
| </span> | ||
| )) |
AtsushiM
requested review from
nabeliwo and
yuzuru-akiyama
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法