chore: Icon系コンポーネントの内部処理をリファクタリングする #5290
Open
+273
−262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
AtsushiM
commented
Jan 16, 2025
| @@ -113,79 +111,92 @@ const wrapper = tv({ | |||
| }, | |||
| }) | |||
|
|
|||
| export const createIcon = (SvgIcon: IconType) => { | |||
There was a problem hiding this comment.
createIconとgenerateIconは処理内容は完全に同じです。
型なども同様であり、aliasとしても存在する理由はありません。
既存のgeenrateIconは内部でcreateIconを呼び出す関係上、余計なオーバーヘッドがかかるデメリットがあるのみでした。
generateIconのほうはsmarthr-uiとして外部提供しているため、
- 既存のgenerateIconを削除
- 既存のcreateIconをgenerateIconにrename
することで整理しました
AtsushiM
commented
Jan 16, 2025
| if (colorName in textColor) { | ||
| return textColor[colorName as keyof typeof textColor] | ||
| export const generateIcon = (SvgIcon: IconType) => { | ||
| const Icon = React.memo<Props>( |
There was a problem hiding this comment.
iconは属性が変わる可能性はかなり低く、また内容がUIからは想像できないほど複雑な処理を行っています。
再レンダリングが必要になる可能性と複雑目な内容を考慮し、デフォルトでmemo化するメリットが大きいと判断、対応しました
AtsushiM
commented
Jan 16, 2025
| size, | ||
| ...props | ||
| }) => { | ||
| const actualAriaHidden = useMemo(() => { |
There was a problem hiding this comment.
aria-hiddenに設定するための値を一つのuseMemoに集約させました
AtsushiM
commented
Jan 16, 2025
| return ( | ||
| <span className={wrapperStyle}> | ||
| {right && text} | ||
| {visuallyHiddenAlt} |
There was a problem hiding this comment.
もともとは alt text の順序で表示されていましたが、UI上の並び順と違うため text alt のように、UI上のアイコンのaltだということがわかる順序に変更しています
AtsushiM
requested review from
yt-ymmt and
hiroki0525
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
関連URL
概要
変更内容
確認方法