add (failing) test that fc_metadata updates as expected #173
Conversation
- Fix issue #173 (filter logic: `units_in`, `units_out`, and `applied`) - There is now a defined direction of filters - Filters are only for instrument response
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #173 +/- ##
==========================================
+ Coverage 58.95% 59.53% +0.57%
==========================================
Files 138 138
Lines 14997 15244 +247
==========================================
+ Hits 8842 9076 +234
- Misses 6155 6168 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@kkappler Have a look at the fixes and see if it works for you. The issue was the metadata was there, but it was not being read in so it was returning the default values. The fix was when calling |
|
@kujaku11 This now passes the tests in aurora (tests/synthetic/test_fourier_coefficients.py) with the addition of a try/except on write_metadata in case the file is read-only |
…nto aurora_issue_310
- Notebook updates change `channel_response_filter` to `channel_response`
The fc decimation level updates via the setter but the changes are not propagating to the h5, and when an fc_group returns metadata (that has been "written" and "updated") the values in the metadata are still the defaults -- not the values that were set.
Inside mth5/tests/version_1/test_fcs.py I placed
test_can_update_decimation_level_metadatawhich highlights the issue.