Fix mt metadata issue 173 #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a method get_response_correction_operation_and_units which tries to determine if the calibration should be applied as a multiplication or division operation, and identifies the calibration operation based on this.
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #174 +/- ##
==========================================
+ Coverage 58.92% 58.95% +0.03%
==========================================
Files 138 138
Lines 14928 14997 +69
==========================================
+ Hits 8796 8842 +46
- Misses 6132 6155 +23
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
- make unit checks in remove_instrument_response use mt_metadata.utils.units
Create access point for complex_response kwargs in remove_instrument_response, specifically: include_decimation, include_time_delay
Implement channel_response_filter.get_list_of_filters_to_remove where response removal occurs.
- only flip the filters that were removed - add some doc about units, remove reference to "hack"
- use get_unit_object, and place full name of unit in channel_ts and channel_metadata
- removed (unused) optional argument "operation" in remove_instrument_response
remove references to filter correction operation
kujaku11
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added some organization to the channel response filter.
see mt_metadata fix_issue_173
for more detail