Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(inspect): api for retrieving service hostnames #11865

Merged
merged 12 commits into from
Jan 10, 2025

Conversation

jakubdyszkiewicz
Copy link
Contributor

@jakubdyszkiewicz jakubdyszkiewicz commented Oct 25, 2024

Motivation

We want to see hostnames of Mesh*Service in the Global CP.

Implementation information

While we could add new KDSService to retrieve stats of a resource in specific zones and then aggregate this an easier (less expensive to execute, faster, don't depend on the zone) option is to calculate the hostname. We have all the resources in global CP already (because HostnameGenerator from zone is synced to global for visibility). It's just a matter of relabeling properly.

Supporting documentation

Fix #10618

@jakubdyszkiewicz jakubdyszkiewicz added the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Oct 25, 2024
@jakubdyszkiewicz jakubdyszkiewicz force-pushed the inspect-hostnames branch 2 times, most recently from fc4908d to b1294d2 Compare October 28, 2024 10:56
@jakubdyszkiewicz jakubdyszkiewicz marked this pull request as ready for review October 28, 2024 11:07
@jakubdyszkiewicz jakubdyszkiewicz requested a review from a team as a code owner October 28, 2024 11:07
@jakubdyszkiewicz jakubdyszkiewicz requested review from michaelbeaumont and slonka and removed request for a team October 28, 2024 11:07
@jakubdyszkiewicz jakubdyszkiewicz removed the ci/skip-test PR: Don't run unit and e2e tests (maybe this is just a doc change) label Oct 28, 2024
api/openapi/specs/api.yaml Outdated Show resolved Hide resolved
api/openapi/specs/api.yaml Show resolved Hide resolved
api/openapi/specs/api.yaml Outdated Show resolved Hide resolved
api/openapi/specs/api.yaml Outdated Show resolved Hide resolved
pkg/api-server/inspect_mesh_service.go Outdated Show resolved Hide resolved
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general ok, but missing some bits that would make it better.

Signed-off-by: Jakub Dyszkiewicz <[email protected]>
Copy link
Contributor

@slonka slonka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - one nit

api/openapi/specs/api.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

  • Is the PR title satisfactory? Is this part of a larger feature and should be grouped using > Changelog?
  • PR description is clear and complete. It Links to relevant issue as well as docs and UI issues
  • This will not break child repos: it doesn't hardcode values (.e.g "kumahq" as an image registry)
  • IPv6 is taken into account (.e.g: no string concatenation of host port)
  • Tests (Unit test, E2E tests, manual test on universal and k8s)
    • Don't forget ci/ labels to run additional/fewer tests
  • Does this contain a change that needs to be notified to users? In this case, UPGRADE.md should be updated.
  • Does it need to be backported according to the backporting policy? (this GH action will add "backport" label based on these file globs, if you want to prevent it from adding the "backport" label use no-backport-autolabel label)

@jakubdyszkiewicz jakubdyszkiewicz merged commit ad81fbf into kumahq:master Jan 10, 2025
13 checks passed
@jakubdyszkiewicz jakubdyszkiewicz deleted the inspect-hostnames branch January 10, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to see VIPs/Hostname on global CP
3 participants