-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(meshtrace): add support for real resources #12173
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Lukasz Dziedziak <[email protected]>
…shService Signed-off-by: Lukasz Dziedziak <[email protected]>
Signed-off-by: Lukasz Dziedziak <[email protected]>
rs *xds.ResourceSet, | ||
proxy *xds.Proxy, | ||
) error { | ||
for uri, resType := range rs.IndexByOrigin(xds.NonMeshExternalService) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not MES?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we don't support policies on Egress, thought maybe no point to add it now
Reviewer Checklist🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
|
Signed-off-by: Lukasz Dziedziak <[email protected]>
… fix-trace-mesh-service
Motivation
Issue #12045 showed that we didn't configure real resources
Implementation information
e1d1ed7 extracted test string to golden files
f6ae3d1 added unit test showing an issue
e7d8c6c implementation of real resource and generated file
Added a function that loops over real resources to configure listeners for MeshService and MeshMultiZoneService. Since we don't have a
kuma.io/service
as a destination, we set the output ofDestinationName(port)
, which is used for clusters.Supporting documentation
Fix #12045