Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meshtrace): add support for real resources #12173

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

lukidzi
Copy link
Contributor

@lukidzi lukidzi commented Dec 4, 2024

Motivation

Issue #12045 showed that we didn't configure real resources

Implementation information

e1d1ed7 extracted test string to golden files
f6ae3d1 added unit test showing an issue
e7d8c6c implementation of real resource and generated file

Added a function that loops over real resources to configure listeners for MeshService and MeshMultiZoneService. Since we don't have a kuma.io/service as a destination, we set the output of DestinationName(port), which is used for clusters.

Supporting documentation

Fix #12045

@lukidzi lukidzi requested a review from a team as a code owner December 4, 2024 14:14
@lukidzi lukidzi requested review from Automaat and lobkovilya and removed request for a team December 4, 2024 14:14
rs *xds.ResourceSet,
proxy *xds.Proxy,
) error {
for uri, resType := range rs.IndexByOrigin(xds.NonMeshExternalService) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not MES?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't support policies on Egress, thought maybe no point to add it now

Copy link
Contributor

github-actions bot commented Dec 6, 2024

Reviewer Checklist

🔍 Each of these sections need to be checked by the reviewer of the PR 🔍:
If something doesn't apply please check the box and add a justification if the reason is non obvious.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MeshTrace not working on deployment without kube service
4 participants