feature: add scikit-learn and tensorflow model validator #34
Conversation
…kumparanian ds evaluate and verify output
…rFlow to hide warnings, errors, and informational messages.
…gs and informational messages)
|
update Readme nya juga ya @Ghefira233 |
kumparanian/ds/model.py
Outdated
| "KBRN, Pekanbaru (MCH): Kloter Tujuh Embarkasi Batam yang mengangkut Jemaah Calon Haji (JCH)" | ||
| ] | ||
|
|
||
| if model_extension == ".pickle" or model_extension == ".pkl": |
tests/ds/model_test.py
Outdated
| error_msg = "Model should contains predict method" | ||
| with self.assertRaisesRegex(AttributeError, error_msg): | ||
| ds.model.verify(file_name) | ||
| with open(self.file_path, "wb") as f: |
There was a problem hiding this comment.
kalau bisa jangan f aja ya 😅
There was a problem hiding this comment.
hoo iya lupa hehe maaf mas
| ) | ||
|
|
||
|
|
||
| def evaluate(model_path, file_path, test_set_path, data_type=None): |
There was a problem hiding this comment.
kira-kira kenapa save, verify, dan evaluate ga dimasukkan ke class Model seperti load ya?
There was a problem hiding this comment.
hmm supaya bisa dipakai secara independen dan ga perlu jadi instance dari class 'Model' sih.. dari code yang sebelumnya juga dia jadi fungsi masing-masing mas. kalo load model nya saja yang jadi fungsi juga gimana mas? jadi ga perlu ada class
…poetry.scripts] in pyproject.toml
…uality checks with 'in' operator
.github/workflows/ci.yml
Outdated
| run: | | ||
| pip install dist/*.whl | ||
|
|
||
| - name: Install make |
There was a problem hiding this comment.
btw aku baru ngeh, make itu mesti diinstall dulu ya, ga otomatatis ada di ubuntu?
There was a problem hiding this comment.
oh iya dia pre installed ya? aku coba remove dulu untuk ngetes
There was a problem hiding this comment.
ok aman mas, https://linuxgenie.net/install-use-make-ubuntu-22-04/#post-13800-_zdv0ivbkawn9
bener ternyata pre installed 🙏 Normally, the make command is pre-installed on your Ubuntu 22.04.
tests/ds/model_test.py
Outdated
|
|
||
| tf_model = Sequential() | ||
| tf_model.add( | ||
| Embedding(input_dim=1000, output_dim=64, input_length=10, name="embedding") |
There was a problem hiding this comment.
aman buat dikecilin lagi ga ya, biar kecilin size model yang buat di test juga?
There was a problem hiding this comment.
aman mas, udah aku kecilin jadi Embedding(input_dim=50, output_dim=4, input_length=10, name="embedding"). sama buat tf_valid_model.keras untuk test juga udah aku kecilin sekarang jadi 604 KB
…sorflow model, replaced TensorFlow model with smaller model architecture
| @@ -13,21 +13,25 @@ license = "kumparan" | |||
| readme = "README.md" | |||
| packages = [ | |||
| { include = "kumparanian" }, | |||
| { include = "kumparanian/de" }, | |||
There was a problem hiding this comment.
kemarin nanya mas malik katanya udah ga di pakai mas terus katanya dihapus aja
|
lgtm |
feature: