Add FromRepr, ToRepr, TryFromKnownRepr derives based on design from #22
#24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fu5ha
commented
Oct 2, 2024
| @@ -102,6 +104,32 @@ fn emit_debug_impl<'a>( | |||
| }) | |||
| } | |||
|
|
|||
| fn path_matches_any_of_our_derives(got_path: &syn::Path, our_derives: &[&str]) -> bool { | |||
There was a problem hiding this comment.
this and some other parts of the macros will have to change some if we ever want to allow providing a custom crate path like some other proc macros do...
Comment on lines
+205
to
+207
| let mut should_emit_repr_helper = false; | ||
| let mut should_emit_variants_helper = false; | ||
| let mut should_emit_alias_helper = false; |
There was a problem hiding this comment.
I was thinking, it might be useful to have configs on the top level attribute macro to force emitting these helpers, in case third party derive macros would want to consume them? But I didn't think it was worth it for now, so I left it.
|
I really appreciate you taking a crack at this, and I'm sorry for not seeing this PR - I've been on an extended vacation. The basic idea behind the code is right, but:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does as the title says, implementing a few derives I want based on the design outlined in #22.
Since attributes we emit from the main attribute proc macro must be defined/consumed by something else (and we can't define helper attributes from an attribute proc macro, only from derive proc macros), we detect when derives are present on the main proc macro and only emit the necessary helper attributes that will actually be consumed.