Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: type of params.page.* #367

Merged
merged 1 commit into from
Dec 12, 2023
Merged

fix: type of params.page.* #367

merged 1 commit into from
Dec 12, 2023

Conversation

nelson6e65
Copy link
Contributor

@nelson6e65 nelson6e65 commented Oct 28, 2023 •
edited
Loading

Those values are actually strings.

?page[limit]=19&page[number]=19&page[after:id]=SayLOC5U5pMj2KQlxCo0

{page: { limit: '19', number: '19', 'after:id': 'SayLOC5U5pMj2KQlxCo0' }}

@nelson6e65
fix: type of params.page.*
db44985 
Those values are actually strings.
joelalejandro
joelalejandro approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@joelalejandro joelalejandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nelson6e65 !

@joelalejandro joelalejandro merged commit e1dd5c6 into kurierjs:main Dec 12, 2023
4 checks passed
@nelson6e65 nelson6e65 deleted the patch-1 branch December 12, 2023 21:11
@joelalejandro
Copy link
Member

@nelson6e65 Unfortunately I need to revert this because KnexProcessor uses this to do math around the paging. It's weird that the CI check didn't catch it :/

@joelalejandro joelalejandro mentioned this pull request Dec 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joelalejandro joelalejandro joelalejandro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nelson6e65 @joelalejandro