Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vk: add workaround for Intel HD/UHD memory leak (#117) #129

Merged
merged 4 commits into from
Jun 13, 2024

Conversation

skejeton
Copy link
Contributor

@skejeton skejeton commented Jun 11, 2024

This will detect an Intel graphics card and apply the fix for leaky descriptor pools.

Copy link
Owner

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!
A few small changes are needed, but overall the approach is good

blade-graphics/src/vulkan/init.rs Outdated Show resolved Hide resolved
blade-graphics/src/vulkan/init.rs Outdated Show resolved Hide resolved
blade-graphics/src/vulkan/mod.rs Outdated Show resolved Hide resolved
blade-graphics/src/vulkan/descriptor.rs Outdated Show resolved Hide resolved
@skejeton
Copy link
Contributor Author

fixed

Copy link
Owner

@kvark kvark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, thank you!

@kvark kvark enabled auto-merge (squash) June 13, 2024 02:00
@kvark kvark merged commit 845cdad into kvark:main Jun 13, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants