vk: ignore non-coherent host-visible memory types #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
Tested this one and the flickering seems to go away! I couldn't reproduce the flickering that reliably on the Blade's own examples but changed Zed editor to use this branch and against that this fixes the issue. |
mrnugget
added a commit
to zed-industries/zed
that referenced
this pull request
Aug 6, 2024
…de params (#15829) Builds on @kvark's PR #15781 by fixing call to Blades `create_texture_view` the arguments of which had changed. Picks up kvark/blade#153 Release Notes: - Fixed Zed flickering on Linux when using Intel graphics. ([#14101](#14101)). --------- Co-authored-by: Dzmitry Malyshau <[email protected]> Co-authored-by: Thorsten Ball <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant to https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30499
Since Blade doesn't expose API to do explicit memory flush/invalidation, let's ignore the affected memory types.