-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass names, scopes, and timings #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
force-pushed
the
pass-name
branch
2 times, most recently
from
September 23, 2024 05:31
3602a01
to
fdc80c0
Compare
kvark
changed the title
Add a label argument to every pass creation
Pass names, scopes, and timings
Sep 25, 2024
This was referenced Sep 25, 2024
Also switches to my own fork of metal-rs for now
Proceeding with using https://github.com/kvark/metal-rs/tree/blade |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps us annotate the command scopes, capture the timers, and put GPU crash markers.
PR also adds the timing support.
Fixes #170
Closes #174
Depends on:
Add ComputePassDescriptorRef::set_dispatch_type gfx-rs/metal-rs#335
Add CounterSampleBuffer::resolve_counter_range gfx-rs/metal-rs#336
Add AccelerationStructurePassDescriptor gfx-rs/metal-rs#337
API
Vulkan
Metal
GLES
Particle example: