Unify temporal and spatial taps #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvark
force-pushed
the
experiment/unified-temporal
branch
from
715368d
to
af8884d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless ReSTIR is multi-pass (e.g. #192), there is really no difference between spatial taps and the temporal tap. This PR unifies them together, which simplifies the code a bit.
Before:
After:
Looks like we are losing a bit of performance. The relevant metric is RT Core Throughput, and it's lower by a bit, probably because the temporal resampling made it a more coherent pattern. But in exchange, the noise level seems reduced on the "move" example.