vk: include Wayland in the Nvidia-Intel workaround #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidbuzz has confirmed that this PR picks Nvidia on their machine. Merging. |
flukejones
reviewed
Mar 18, 2024
| //Note: this is somewhat broad across X11/Wayland and different drivers. | ||
| // It could be narrower, but at the end of the day if the user forced Prime | ||
| // for GLX it should be safe to assume they want it for Vulkan as well. | ||
| intel_unable_to_present: is_nvidia_prime_forced(), |
There was a problem hiding this comment.
This only applies to Xorg. Wayland completely ignores this, but using it as an indication of desired behaviour may work here.
There was a problem hiding this comment.
The general expected behaviour of desktop applications is that they default to igpu unless one of
PrefersNonDefaultGPU=false
X-KDE-RunOnDiscreteGpu=false
is set in the application.desktop file, or some desktops provide a method to offload with right-click menu.
However when it comes to games, typically vulkan defaults to dgpu. While opengl requires intervention.
mikayla-maki
added a commit
to zed-industries/zed
that referenced
this pull request
Apr 10, 2024
Release Notes: - N/A Picks up kvark/blade#105, kvark/blade#97, and more Switches the presentation to be non-blocking, which will improve the latency slightly. Allows to start playing with GLES backend, e.g. ```bash cd crates/gpui RUSTFLAGS="--cfg gles" CARGO_TARGET_DIR=./target-gl cargo run --example hello_world ``` It doesn't currently render properly due to an issue that needs investigation, see kvark/blade#105 (comment) But at least it's a start Co-authored-by: Mikayla Maki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #95, cc @flukejones