Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check if excluded key exists before deletion #52

Closed
wants to merge 1 commit into from

Conversation

kelvinhammond
Copy link

Otherwise it throws an exceptions if the meta exclude include an extra key which is either already removed or doesn't exists such as 'id' or 'pk'.

@kvesteri
Copy link
Owner

I think it is desirable that the exclude returns exception for unknown keys. Imagine a situation where user makes a typo typing a field name in the exclude. I think we need to still think about this.

@kelvinhammond
Copy link
Author

Superseded by #56

@kelvinhammond kelvinhammond deleted the patch-1 branch February 16, 2014 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants