Catch OSError when executing os.fsync which is not compatible with network FS #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…twork disks or vagrant/virtualbox vboxfs
|
This should fix #67 |
benjamb
reviewed
Jul 6, 2022
| @@ -429,6 +432,8 @@ def _write(filename, contents): | |||
| try: | |||
| dfd = os.open(os.path.join(os.path.realpath('.'), os.path.dirname(filename)), os.O_DIRECTORY) | |||
| os.fsync(dfd) | |||
| except: | |||
There was a problem hiding this comment.
This probably ought to catch something specific, rather than an empty except. Same thing above.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Network disks or vagrant/virtualbox vboxfs are not compatible with os.fsync