Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Labels for Gen 5 Trainer Records (plus renamed flag) #4362

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

WonderSquid
Copy link
Contributor

@WonderSquid WonderSquid commented Sep 25, 2024

The records stuff is probably really, really bad, and I hope what I have here is at least semi-useable. Apologies in advance.

Also relabelled an incorrectly labelled flag on every language but Chinese, since there seemed to be some confusion as to what the trade trainer in Nacrene is named on the wiki, and I don't have a Chinese copy of the game to go check if the wiki is wrong or if the flag name is.

@WonderSquid
Copy link
Contributor Author

please do not look directly at my spaghetti code i'll figure something out

@Lusamine
Copy link
Collaborator

Lusamine commented Oct 23, 2024

Also relabelled an incorrectly labelled flag on every language but Chinese, since there seemed to be some confusion as to what the trade trainer in Nacrene is named on the wiki, and I don't have a Chinese copy of the game to go check if the wiki is wrong or if the flag name is.

If you don't know what the flag should be named, I would suggest reverting it to English and let someone who speaks Chinese translate it. Focus on making the PR work, and don't let the translation issue hold it up.

Gen 5 doesn't have a official Chinese version so it isn't a matter of finding a copy of the game to learn the official translation.

If you're having trouble making this PR compile, it might be worth splitting it into two:

  1. Rename the flags, and revert any unknown translations to English.
  2. Whatever other enhancements you are trying to add.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants