Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ModuleCatalog] Add .spec.associatedResources to ModuleTemplate #1843

Closed
3 tasks done
c-pius opened this issue Sep 6, 2024 · 0 comments · Fixed by #1923
Closed
3 tasks done

[ModuleCatalog] Add .spec.associatedResources to ModuleTemplate #1843

c-pius opened this issue Sep 6, 2024 · 0 comments · Fixed by #1923
Assignees
Labels
API Denotes that an issue is tied to the potential change of the API kind/feature Categorizes issue or PR as related to a new feature.

Comments

@c-pius
Copy link
Contributor

c-pius commented Sep 6, 2024

Description

In #1681 it has been decided to add info about resources associated to a module to ModuleTemplates. We need to update the ModuleTemplate to include this information.

The information shall look as follows:

spec:
  associatedResources:
  - group: networking.istio.io
    version: v1alpha3
    kind: gateways
  - group: networking.istio.io
    version: v1alpha3
    kind: virtualservices

.spec.associatedResources is OPTIONAL (for compatibility reasons). The items in an individual entry are REQUIRED. It should be checked whether existing K8s types and validations can be re-used.

Reasons

Enables CLI and dashboard to show a message about what resources must be cleaned when uninstalling a module.

Acceptance Criteria

  • re-used K8s types if possible
  • .spec.associatedResources added to ModuleTemplate
  • Added an entry to Modularization API Upgrade #776 that spec.associatedResources must be added as required in a future major API version

Feature Testing

No response

Testing approach

No response

Attachments

No response

@c-pius c-pius added kind/feature Categorizes issue or PR as related to a new feature. API Denotes that an issue is tied to the potential change of the API labels Sep 6, 2024
@lindnerby lindnerby self-assigned this Oct 1, 2024
@lindnerby lindnerby linked a pull request Oct 4, 2024 that will close this issue
@nesmabadr nesmabadr assigned nesmabadr and unassigned lindnerby Oct 4, 2024
@lindnerby lindnerby assigned lindnerby and unassigned nesmabadr Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Denotes that an issue is tied to the potential change of the API kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants