Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add AssociatedResources to ModuleTemplate spec #1923

Merged
merged 4 commits into from
Oct 4, 2024

Conversation

lindnerby
Copy link
Member

@lindnerby lindnerby commented Oct 4, 2024

Description

Changes proposed in this pull request:

  • Adds the optional AssociatedResources field to ModuleTemplate
  • Add documentation

Related issue(s)

@lindnerby lindnerby requested review from a team as code owners October 4, 2024 10:22
@kyma-bot kyma-bot added cla: yes Indicates the PR's author has signed the CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 4, 2024
@lindnerby lindnerby linked an issue Oct 4, 2024 that may be closed by this pull request
3 tasks
nesmabadr
nesmabadr previously approved these changes Oct 4, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 4, 2024
mmitoraj
mmitoraj previously approved these changes Oct 4, 2024
@lindnerby lindnerby enabled auto-merge (squash) October 4, 2024 11:50
@lindnerby lindnerby dismissed stale reviews from mmitoraj and nesmabadr via 3268627 October 4, 2024 11:55
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 4, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 4, 2024
@kyma-bot kyma-bot removed the lgtm Looks good to me! label Oct 4, 2024
@kyma-bot kyma-bot added the lgtm Looks good to me! label Oct 4, 2024
@lindnerby lindnerby merged commit cd2b4a2 into kyma-project:main Oct 4, 2024
33 of 34 checks passed
@lindnerby lindnerby deleted the associated-resources branch October 4, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Indicates the PR's author has signed the CLA. lgtm Looks good to me! size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ModuleCatalog] Add .spec.associatedResources to ModuleTemplate
4 participants