feat: Module catalogue improvements #1892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyma-bot
added
cla: yes
Tomasz-Smelcerz-SAP
changed the title
chore: Sync main to feature branch (kyma-project#1718) chore: Refactor NewCachedDescriptorProvider (kyma-project#1695) docs: Update KLM Local Test Setup Guide (kyma-project#1680) chore: Configure different requeue intervals for Manifest reconciliation (kyma-project#1690) feat: Drop multiple ways to reference modules in Kyma CR (kyma-project#1672) chore: Bump k8s deps (kyma-project#1703) fix: Manifest CR should update by moduletemplate generation changes (kyma-project#1702) feat: Add Version to Kyma.Spec.Modules (kyma-project#1694) chore: Refactor NewCachedDescriptorProvider (kyma-project#1695) chore: Update branch to main (kyma-project#1753) feat: Module catalog improvements implementation (kyma-project#1748) feat: Remove kyma.spec.modules[].version from api (kyma-project#1837) --------- Co-authored-by: Christoph Schwägerl <[email protected]> Co-authored-by: Nesma Badr <[email protected]> Co-authored-by: Benjamin Lindner <[email protected]> Co-authored-by: Tomasz Smelcerz <[email protected]>
Tomasz-Smelcerz-SAP
force-pushed
the
feat/module-catalogue-improvements-rebase-squash
branch
from
387c943
to
3bd7877
Compare
ruanxin
reviewed
Sep 27, 2024
| // The Version and Channel are mutually exclusive options. | ||
| // The regular expression come from here: https://semver.org/#is-there-a-suggested-regular-expression-regex-to-check-a-semver-string | ||
| // json:"-" to disable installation of specific versions until decided to roll this out | ||
| // see https://github.com/kyma-project/lifecycle-manager/issues/1847 |
There was a problem hiding this comment.
Can we mention these changes here on #1847?
Then later when need to support the version field, we are clear on what need to change. For example, change this Version to json:version, enable skipped e2e test: https://github.com/kyma-project/lifecycle-manager/pull/1892/files#diff-d8d3cb73bc106e357ced5f42d78f3a065c63307df9a8e33268e2161d61d686f7R15, and something you think worth to mention.
1 task
ruanxin
approved these changes
Sep 27, 2024
This was referenced Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR contains all the changes from module-catalogue-improvements feature branch, with necessary fixes related to the changes on the
mainbranch, rebased on themainbranch at commit: 1f2e30d.**Note for reviewer: ** The dummy PR was used to test the changes here, due to the issues we currently have with testing PR that contain test code changes.
[some] Changes proposed in this pull request:
Related issue(s)
#1472