fix: query and error logging both occur on error. #796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
changed the title
koskimas
approved these changes
Dec 29, 2023
koskimas
force-pushed
the
fix-double-logging-on-error
branch
from
7795366 to
7bdd416
Compare
thecodrr
pushed a commit
to thecodrr/kysely
that referenced
this pull request
Sep 3, 2024
* deny logging query and error onerror. also deny catching custom log err. * move caughtError declaration so it doesn't take up "execution time". * fix defaultLogger error handling when not Error. * test logging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #743.
This is better than the suggested solution in the comment section. If we moved query logging to the
trybody, we'd catch errors in user's logging logic. User has all the context necessary to handle his logic's exceptions and print necessary errors.Regarding timing mismatch, not much we can do about it.
Went ahead and fixed
defaultLogger's error handling when notError- it was printing[object Object].