Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(server): cache props #17

Merged
merged 3 commits into from
Apr 22, 2024
Merged

fix(server): cache props #17

merged 3 commits into from
Apr 22, 2024

Conversation

remcolakens
Copy link
Collaborator

Context

The cache header always defaults to cache: default, meaning you get errors when using it in combination with revalidate.

Changes

  • Removed the default value

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have tested my code for breaking changes and added the corresponding footer in this PR if needed
  • I have added tests that prove my fix is effective or that my feature works

Copy link

changeset-bot bot commented Apr 22, 2024

🦋 Changeset detected

Latest commit: bf22387

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@labdigital/graphql-fetcher Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@remcolakens remcolakens changed the title fix: cache props fix(server): cache props Apr 22, 2024
@blurrah blurrah merged commit b14681d into main Apr 22, 2024
4 checks passed
@blurrah blurrah deleted the fix/cache-props branch April 22, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants