feat: also handle 404 with a response body

labd · Mar 21, 2024 · 410dbfb · 410dbfb
1 parent cced7ec
commit 410dbfb
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/languages/go/src/main/kotlin/io/vrap/codegen/languages/go/client/ClientFileProducer.kt b/languages/go/src/main/kotlin/io/vrap/codegen/languages/go/client/ClientFileProducer.kt
@@ -73,6 +73,7 @@ class ClientFileProducer(
                 |
                 |// NewClient creates a new client based on the provided ClientConfig
                 |func NewClient(cfg *ClientConfig) (*Client, error) {
+                |
                 |    userAgent := cfg.UserAgent
                 |    if userAgent == "" {
                 |        userAgent = GetUserAgent()

diff --git a/languages/go/src/main/kotlin/io/vrap/codegen/languages/go/client/MethodRenderer.kt b/languages/go/src/main/kotlin/io/vrap/codegen/languages/go/client/MethodRenderer.kt
@@ -321,6 +321,12 @@ class GoMethodRenderer(
                         |    }
                         |    return result, nil
                         """.trimMargin()
+                } else if (it.second.toInt() == 404) {
+                    // If status code is 404 and has a response body we return a sentinel value
+                    """
+                            |case ${it.second.toInt()}:
+                            |    return ${returnValue}ErrNotFound
+                            """.trimMargin()
                 } else {
                     // If status is failure and response body is defined we return the marshalled error
                     """