Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: rework codebase using universal addon #4

Merged
merged 7 commits into from
Jun 27, 2024

Conversation

jaygridley
Copy link
Member

@jaygridley jaygridley commented Jun 3, 2024

Description

Breaking Changes

  • Change code base to use universal addon as template
  • Update KEDA to 2.14. This version changes how Service Accounts are created resulting in a change of input variables. Now the inputs might be scoped to individual KEDA components - operator (keda_operator_*), metrics server (keda_metric_server_*) and webhooks (keda_webhooks_*).

Migration guide

You can either leave all IRSA related variables and only rename irsa_policy_allow_assume_roles to irsa_assume_role_arns as is resulting in all 3 new Service Accounts to have the same configuration or you can decide to remove them and add a new set of corresponding variables for individual components, see variables.tf for a reference.

Type of change

  • A bug fix (PR prefix fix)
  • A new feature (PR prefix feat)
  • A code change that neither fixes a bug nor adds a feature (PR prefix refactor)
  • Adding missing tests or correcting existing tests (PR prefix test)
  • Changes that do not affect the meaning of the code like white-spaces, formatting, missing semi-colons, etc. (PR prefix style)
  • Changes to our CI configuration files and scripts (PR prefix ci)
  • Documentation only changes (PR prefix docs)

How Has This Been Tested?

  • Used this PR branch as a source for LARA addon test and installed KEDA, checked its deployment status

@jaygridley jaygridley self-assigned this Jun 3, 2024
@jaygridley jaygridley requested a review from dojci June 3, 2024 20:15
Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaygridley jaygridley requested a review from dojci June 14, 2024 08:50
Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing IRSA mandatory features:

variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
addon-irsa.tf Show resolved Hide resolved
addon-irsa.tf Show resolved Hide resolved
addon-irsa.tf Outdated Show resolved Hide resolved
variables-addon-irsa.tf Outdated Show resolved Hide resolved
@jaygridley jaygridley force-pushed the feat/universal-addon-base branch from d697211 to ddee442 Compare June 26, 2024 14:50
@jaygridley jaygridley requested a review from dojci June 26, 2024 14:58
@jaygridley jaygridley force-pushed the feat/universal-addon-base branch from 88b83c5 to ed313a4 Compare June 27, 2024 13:29
Copy link
Member

@dojci dojci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaygridley jaygridley merged commit 08afbfe into main Jun 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants