-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: rework codebase using universal addon #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing IRSA mandatory features:
d697211
to
ddee442
Compare
88b83c5
to
ed313a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Breaking Changes
keda_operator_*
), metrics server (keda_metric_server_*
) and webhooks (keda_webhooks_*
).Migration guide
You can either leave all IRSA related variables and only rename
irsa_policy_allow_assume_roles
toirsa_assume_role_arns
as is resulting in all 3 new Service Accounts to have the same configuration or you can decide to remove them and add a new set of corresponding variables for individual components, see variables.tf for a reference.Type of change
fix
)feat
)refactor
)test
)style
)ci
)docs
)How Has This Been Tested?