Skip to content
This repository has been archived by the owner on Jul 16, 2024. It is now read-only.

feat: replace aetcd3 with etcetra #124

Merged
merged 12 commits into from
Mar 23, 2022
Merged

feat: replace aetcd3 with etcetra #124

merged 12 commits into from
Mar 23, 2022

Conversation

kyujin-cho
Copy link
Member

@kyujin-cho kyujin-cho commented Mar 15, 2022

This commit adapts lablup/etcetra, our own etcd API client as our new etcd wrapper backend. This resolves lablup/backend.ai#383.

@kyujin-cho kyujin-cho self-assigned this Mar 15, 2022
@kyujin-cho kyujin-cho added this to the 22.03 milestone Mar 15, 2022
@codecov
Copy link

codecov bot commented Mar 15, 2022

Codecov Report

Merging #124 (31becfc) into main (3a6466f) will increase coverage by 0.06%.
The diff coverage is 84.31%.

@@            Coverage Diff             @@
##             main     #124      +/-   ##
==========================================
+ Coverage   78.30%   78.36%   +0.06%     
==========================================
  Files          24       24              
  Lines        3268     3185      -83     
==========================================
- Hits         2559     2496      -63     
+ Misses        709      689      -20     
Impacted Files Coverage Δ
src/ai/backend/common/docker.py 77.40% <33.33%> (-1.09%) ⬇️
src/ai/backend/common/events.py 85.32% <76.19%> (-0.66%) ⬇️
src/ai/backend/common/etcd.py 88.94% <90.27%> (+5.92%) ⬆️
src/ai/backend/common/plugin/__init__.py 90.24% <100.00%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3a6466f...31becfc. Read the comment docs.

@achimnol
Copy link
Member

achimnol commented Mar 21, 2022

image

image

There seems to be some packaging issue?

@achimnol
Copy link
Member

Sent a PR to fix it: lablup/etcetra#5

achimnol added a commit to lablup/backend.ai-manager that referenced this pull request Mar 23, 2022
* Check closed/stopped flags in event dispatchers and global timers
  to prevent producing and handling stale event messages.
  (lablup/backend.ai-common#124)
* Give a small chance to the event dispatcher to finish up remaining
  handler tasks before shutdown.
* Update aiotools to v1.5.5 and apply wait_timeout on shutdown
@achimnol achimnol merged commit 2f3bc74 into main Mar 23, 2022
@achimnol achimnol deleted the feature/adapt-etcetra branch March 23, 2022 05:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Write our own distributed locking (async etcd3 with concurrency API or aioredis v2 redlock)
2 participants