Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FR-46] fix: The ScrollBottomHandlerButton is displayed even when the chat message is empty. #2996

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[FR-46] fix: The ScrollBottomHandlerButton is displayed even when the chat message is empty. #2996

wants to merge 1 commit into from
+57 −38

Conversation

agatha197
Copy link
Contributor

@agatha197 agatha197 commented Jan 3, 2025 •
edited
Loading

resolves https://lablup.atlassian.net/browse/FR-263

Enhances chat message list scrolling behavior by:

  • Adding user scroll tracking to prevent auto-scrolling when user manually scrolls
  • Hiding the scroll-to-bottom button when there are no messages
  • Resetting user scroll state when manually clicking the scroll button
  • Improving scroll event handling with wheel and general scroll detection

Checklist:

  • Mention to the original issue
  • Documentation
  • Minium required manager version
  • Specific setting for review (eg., KB link, endpoint or how to setup)
  • Minimum requirements to check during review
  • Test case(s) to demonstrate the difference of before/after

@agatha197 agatha197 mentioned this pull request Jan 3, 2025
Merged
8 tasks
@github-actions github-actions bot added the size:XS ~10 LoC label Jan 3, 2025
@agatha197 agatha197 mentioned this pull request Jan 3, 2025
Merged
6 tasks
@agatha197 Graphite App
Copy link
Contributor Author

agatha197 commented Jan 3, 2025 •
edited
Loading

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • flow:merge-queue - adds this PR to the back of the merge queue
  • flow:hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has required the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@agatha197 agatha197 mentioned this pull request Jan 3, 2025
Merged
2 tasks
@agatha197 agatha197 requested a review from yomybaby January 3, 2025 11:20
@agatha197 agatha197 force-pushed the feature/provide-media-functionality-and-token-related-information_ branch from a0349cd to 4fe0a70 Compare January 6, 2025 01:33
@agatha197 agatha197 force-pushed the style/adjust-atBottomThreshold branch from 93f4e4c to 878d953 Compare January 6, 2025 01:33
@agatha197 agatha197 mentioned this pull request Jan 6, 2025
Draft
6 tasks
@agatha197 agatha197 force-pushed the feature/provide-media-functionality-and-token-related-information_ branch from 4fe0a70 to 3a42102 Compare January 6, 2025 02:30
@agatha197 agatha197 force-pushed the style/adjust-atBottomThreshold branch from 878d953 to 750a200 Compare January 6, 2025 02:31
@yomybaby yomybaby mentioned this pull request Jan 6, 2025
Merged
@yomybaby yomybaby changed the base branch from feature/provide-media-functionality-and-token-related-information_ to graphite-base/2996 January 6, 2025 03:30
@yomybaby yomybaby force-pushed the style/adjust-atBottomThreshold branch from 750a200 to 75ad83c Compare January 6, 2025 03:32
@yomybaby yomybaby force-pushed the graphite-base/2996 branch from 3a42102 to e02fd86 Compare January 6, 2025 03:32
@yomybaby yomybaby changed the base branch from graphite-base/2996 to main January 6, 2025 03:33
@yomybaby yomybaby force-pushed the style/adjust-atBottomThreshold branch from 75ad83c to da3ef24 Compare January 6, 2025 03:33
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 6, 2025 •
edited
Loading

Coverage report for ./react

St.❔
 Category Percentage Covered / Total
🔴 Statements
4.97% (-0.01% 🔻)
 398/8001
🔴 Branches
4.3% (-0.01% 🔻)
 237/5509
🔴 Functions
2.98% (-0% 🔻)
 78/2618
🔴 Lines
4.89% (-0.01% 🔻)
 383/7828

Test suite run success

124 tests passing in 14 suites.

Report generated by 🧪jest coverage report action from 8976fe8

@agatha197 agatha197 marked this pull request as draft January 6, 2025 04:35
@agatha197 agatha197 force-pushed the style/adjust-atBottomThreshold branch from da3ef24 to 9a85b19 Compare January 6, 2025 04:52
@github-actions github-actions bot added size:M 30~100 LoC and removed size:XS ~10 LoC labels Jan 6, 2025
@agatha197 agatha197 marked this pull request as ready for review January 6, 2025 04:53
@agatha197 agatha197 marked this pull request as draft January 6, 2025 04:55
@agatha197 agatha197 force-pushed the style/adjust-atBottomThreshold branch 4 times, most recently from 73bd5d6 to 5341d21 Compare January 6, 2025 05:43
@agatha197 agatha197 force-pushed the style/adjust-atBottomThreshold branch from 5341d21 to 8976fe8 Compare January 6, 2025 05:45
@agatha197 agatha197 marked this pull request as ready for review January 6, 2025 05:50
yomybaby
yomybaby requested changes Jan 7, 2025
View reviewed changes
Copy link
Member

@yomybaby yomybaby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While receiving a long response, try scrolling and clicking the "Go to bottom" button. The behavior is still not natural.

@agatha197 agatha197 marked this pull request as draft January 10, 2025 01:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yomybaby yomybaby yomybaby requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@agatha197 agatha197

Labels
size:M 30~100 LoC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@agatha197 @yomybaby