-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Replace asyncio.gather()
with aiotools.PersistentTaskGroup()
for kernel creation tasks
#1129
base: main
Are you sure you want to change the base?
Conversation
.fix.md -> 1129.fix.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to refactor this part to use aiotools.PersistentTaskGroup
.
BaseException
to the checklist to filter out asyncio.CancelledError
raised during kernel creationasyncio.gather()
with aiotools.PersistentTaskGroup()
for kernel creation tasks
I have published aiotools v1.6.0 which introduces Though, it requires Python 3.11 to handle timeouts correctly (this may be fixable but I don't have enough time now...) while its basic functionality still works with Python 3.10. |
It spreads a traceback message when an (venv) rapsealk@MacBook-Pro aiolabs % python main.py
Traceback (most recent call last):
File "/Users/rapsealk/Desktop/git/aiolabs/venv/lib/python3.10/site-packages/aiotools/taskgroup/persistent_compat.py", line 163, in _task_wrapper
ret = await coro
File "/Users/rapsealk/Desktop/git/aiolabs/main.py", line 16, in random_task
raise Exception(str(id))
Exception: 3
INFO:__main__:results: [0, 1, 2]
INFO:__main__:errors: [Exception('3')] |
This is on hold until I finish refactoring of aiotools with Supervisor and TaskScope. |
Under experimentation at achimnol/aiotools#58. |
This PR resolves #1128