Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added API key to be passed as an environment variable #40

Merged
merged 2 commits into from
Jan 25, 2021

Conversation

PatrickAlphaC
Copy link
Contributor

This addresses #39

All tests pass now. If you run the tests without an API key they hit rate limits. Also modified some formatting.

@lagerfeuer
Copy link
Owner

Thanks for the contribution!
I'll think it over, I would like to combine it with #21 (in addition to #39) if possible.
Also, I'd like to add the feature to pass the API key via an environment variable.

@PatrickAlphaC
Copy link
Contributor Author

If you read the new readme it addresses setting it as an environment variable. Also #21 is a separate issue, I don't think having them in the same PR makes sense.

@lagerfeuer
Copy link
Owner

If you read the new readme it addresses setting it as an environment variable.

Ah, I missed that, sorry, busy week.

Also #21 is a separate issue, I don't think having them in the same PR makes sense.

Not like this, no. The point is to pass a dict to the get function so arbitrary URL parameters can be defined, the API key being one of them. So no, it's not separate, you just implemented it differently.

That being said, I feel like this feature should be a part of the library, I am going to merge it. Thanks for your help!

@lagerfeuer lagerfeuer merged commit 3a75994 into lagerfeuer:master Jan 25, 2021
@lagerfeuer lagerfeuer mentioned this pull request Jan 25, 2021
@PatrickAlphaC
Copy link
Contributor Author

All good! Thanks for creating the package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants