Use `std::vector` in `Signal` #1016

This makes updates easier, as only one of each method will need to be changed. The other overloads just wrap the parameters into a `Delegate`, and then pass it to the main overload.

Currently we are using `std::set`, which has implicit existence checks for the `insert` and `delete` operations. However, `std::set` requires the stored items to be "less than" comparable. The custom `Delegate` class has a custom `operator<`, while `std::function` does not. If we use `std::vector`, we won't need a custom `operator<`. We will however need to do manual existence checks when adding or removing delegates from the collection. As an aside, for small collections, it's faster to iterate through a `std::vector` than other more complex collections. The benefits of using `std::set` for fast lookup only become apparent when the collection size grows. As most `Signal` objects typically have at most one connection, we'd be better off using `std::vector` for faster operations.

A `std::vector` will be implicitly initialized.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use `std::vector` in `Signal` #1016

Use `std::vector` in `Signal` #1016

Commits on Dec 7, 2021

Use std::vector in Signal #1016

Use std::vector in Signal #1016

Commits on Dec 7, 2021

Use `std::vector` in `Signal` #1016

Use `std::vector` in `Signal` #1016