Skip to content

Commit

Permalink
SUBMARINE-1417. Retrieve SUBMARINE_AUTH_SECRET from environment varia…
Browse files Browse the repository at this point in the history
…ble instead of using hard-coded value
  • Loading branch information
laiyousin committed Mar 26, 2024
1 parent 246ecee commit e682d82
Showing 1 changed file with 16 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,21 @@

public class SubmarineConfVars {
private static final Logger LOG = LoggerFactory.getLogger(SubmarineConfVars.class);
/**
* Retrieves the secret from the environment variable "SUBMARINE_AUTH_DEFAULT_SECRET".
* Throws runtimeException if the environment variable is not set or empty.
*
* @return The secret as a String
*/
private static String getSecretFromEnv() {
String secret = System.getenv("SUBMARINE_AUTH_SECRET");
if (secret == null || secret.isEmpty()) {
throw new RuntimeException(
"Environment variable SUBMARINE_JWT_SECRET is not set." +
"Please configure a secure key.");
}
return secret;
}
public enum ConfVars {
SUBMARINE_CONF_DIR("submarine.conf.dir", "conf"),
SUBMARINE_LOCALIZATION_MAX_ALLOWED_FILE_SIZE_MB(
Expand Down Expand Up @@ -93,7 +108,7 @@ public enum ConfVars {

/* auth */
SUBMARINE_AUTH_TYPE("submarine.auth.type", "simple"),
SUBMARINE_AUTH_DEFAULT_SECRET("submarine.auth.default.secret", "SUBMARINE_SECRET_12345678901234567890"),
SUBMARINE_AUTH_DEFAULT_SECRET("submarine.auth.default.secret", getSecretFromEnv()),
SUBMARINE_AUTH_MAX_AGE_ENV("submarine.auth.maxAge", 60 * 60 * 24);

private String varName;
Expand Down

0 comments on commit e682d82

Please sign in to comment.