Skip to content

Commit

Permalink
Merge pull request #33 from lakejason0/dev-33
Browse files Browse the repository at this point in the history
Migrate templateDirectory option to skin.json
  • Loading branch information
winstonsung authored Jan 27, 2024
2 parents 8acc2a2 + 2dfcc0a commit 0c690f9
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 5 deletions.
3 changes: 2 additions & 1 deletion RELEASE-NOTES-1.1.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,12 +65,13 @@ Below only new and removed languages are listed.

### Deprecations

* (issue #24) Converted to the new hook system.
* (T262067, issue #33) Migrated `templateDirectory` option to `skin.json`.
*

### Other changes

* (issue #22) Fixed capitalization in README.
* (issue #24) Converted to the new hook system.
* Reordered skin.json based on mediawiki/core `docs/extension.schema.v2.json`
(`6d71df9`).
* (issue #28, #29) Added documentations.
Expand Down
4 changes: 0 additions & 4 deletions includes/SkinLakeus.php
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,11 @@
use TemplateParser;

class SkinLakeus extends SkinMustache {

public const TEMPLATE_DIR = __DIR__ . '/templates';

/**
* @param BagOStuff $localServerObjectCache
* @param array $options
*/
public function __construct( BagOStuff $localServerObjectCache, array $options ) {
$options['templateDirectory'] = self::TEMPLATE_DIR;
parent::__construct( $options );

$this->templateParser = new TemplateParser( $this->options['templateDirectory'], $localServerObjectCache );
Expand Down
1 change: 1 addition & 0 deletions skin.json
Original file line number Diff line number Diff line change
Expand Up @@ -235,6 +235,7 @@
"args": [
{
"name": "lakeus",
"templateDirectory": "includes/templates",
"responsive": true,
"styles": [
"mediawiki.hlist",
Expand Down

0 comments on commit 0c690f9

Please sign in to comment.