[Rust] Datafusion Catalog Support #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mag1c1an1
force-pushed
the
catalog
branch
2 times, most recently
from
3111d2d
to
3fb49c0
Compare
Ceng23333
reviewed
Jan 22, 2024
There was a problem hiding this comment.
fixed by applying rustfmt
Ceng23333
reviewed
Jan 22, 2024
| let np = Namespace { | ||
| namespace: "default".to_string(), | ||
| properties: serde_json::to_string(&LakeSoulTableProperty { | ||
| hash_bucket_num: Some(4), |
There was a problem hiding this comment.
hash_bucket_num is a table property.
|
|
||
|
|
||
| #[test_log::test] | ||
| fn simple_sql_test() { |
There was a problem hiding this comment.
There should be more SQL tests.
| @@ -0,0 +1,386 @@ | |||
| mod catalog_tests { | |||
There was a problem hiding this comment.
Copy-right info is required.
| use std::collections::HashMap; | ||
| use std::sync::Arc; | ||
|
|
||
| use std::sync::{Arc}; |
|
|
||
|
|
||
| /// A metadata wrapper | ||
| pub struct LakeSoulCatalog { |
There was a problem hiding this comment.
LakeSoulCatalog and LakeSoulNamespce can be separated from mod.rs.
rust/lakesoul-io/Cargo.toml
Outdated
| @@ -33,11 +33,12 @@ hdrs = { git = "https://github.com/lakesoul-io/hdrs.git", branch = "main", featu | |||
| lazy_static = "1.4.0" | |||
| chrono = "0.4" | |||
| serde_json = { workspace = true } | |||
| log = { workspace = true } | |||
| tracing = {version = "0.1.40"} | |||
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
Signed-off-by: mag1c1an1 <[email protected]>
xuchen-plus
changed the title
Signed-off-by: mag1c1an1 <[email protected]>
Ceng23333
approved these changes
Jan 26, 2024
| &self, | ||
| name: &str, | ||
| schema: Arc<dyn SchemaProvider>, | ||
| ) -> lakesoul_io::lakesoul_io_config::Result<Option<Arc<dyn SchemaProvider>>> { |
There was a problem hiding this comment.
use datafusion::error::Result
| @@ -89,7 +104,7 @@ impl MetaDataClient { | |||
| } | |||
|
|
|||
| async fn execute_insert(&self, insert_type: i32, wrapper: JniWrapper) -> Result<i32> { | |||
| for times in 0..self.max_retry { | |||
| for times in 0..self.max_retry as i64 { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #424
Due to the restriction of datafusion's api,
CREATE EXTERNAL TABLE ...is not supported.Supported SQL:
CREATE SCHEMA;DROP TABLE;SELECT ...;SHOW TABLES;SHOW COLUMNS