Add Wasm Support for kotlin-document-store #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ce set code and adapting it to WasmJs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically copying js source set code and adapting it to WasmJs. Since dynamic is not available in WasmJs and Promise requires a type that extends JsAny, ive had to replace all Any's and Array's and String's in Promise scope to Wasm Js versions of them (JsArray, JsString,JsAny) while allowing nullability. Since Unit is not a valid JsAny, ive had to replace it with JsAny? since i think there is no other way.
Tested in my browser and it worked. Let me know if you want any changes! (ive tried putting all in a webmain source set but definedExternally, dynamic and needing the Js variants in Wasm, ive given up and let every source set have their own impls)
(i think tests hang with promise, so idk if remove them or not)