Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Coalesce all compatible no-op libfuncs into a single function. #919

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Coalesce all compatible no-op libfuncs into a single function. #919

wants to merge 6 commits into from
+189 −553

Conversation

azteca1998
Copy link
Collaborator

Checklist

  • Linked to Github Issue
  • Unit tests added
  • Integration tests added.
  • This change requires new documentation.
    • Documentation has been added/updated.

@azteca1998 azteca1998 linked an issue Nov 13, 2024 that may be closed by this pull request
Make the no-op libfuncs cleaner #863
Open
@azteca1998 azteca1998 marked this pull request as ready for review November 13, 2024 17:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Benchmarking results

Benchmark for program factorial_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.020 ± 0.250 10.788 11.433 8.18 ± 0.19
cairo-native (embedded AOT) 3.445 ± 0.013 3.432 3.469 2.56 ± 0.01
cairo-native (embedded JIT using LLVM's ORC Engine) 3.261 ± 0.016 3.236 3.284 2.42 ± 0.01
cairo-native (standalone AOT with -march=native) 1.348 ± 0.002 1.346 1.352 1.00

Benchmark for program fib_2M

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 11.155 ± 0.341 10.643 11.436 142.82 ± 4.39
cairo-native (embedded AOT) 3.033 ± 0.024 3.000 3.072 38.83 ± 0.33
cairo-native (embedded JIT using LLVM's ORC Engine) 2.819 ± 0.027 2.775 2.872 36.09 ± 0.36
cairo-native (standalone AOT with -march=native) 0.078 ± 0.000 0.078 0.079 1.00

Benchmark for program logistic_map

Open benchmarks
Command Mean [s] Min [s] Max [s] Relative
Cairo-vm (Rust, Cairo 1) 4.377 ± 0.019 4.356 4.414 18.07 ± 0.09
cairo-native (embedded AOT) 3.204 ± 0.021 3.175 3.237 13.23 ± 0.09
cairo-native (embedded JIT using LLVM's ORC Engine) 3.114 ± 0.022 3.075 3.159 12.86 ± 0.10
cairo-native (standalone AOT with -march=native) 0.242 ± 0.001 0.242 0.244 1.00

@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.76923% with 30 lines in your changes missing coverage. Please review.

Project coverage is 83.00%. Comparing base (ebfa9a1) to head (6fd6786).

Files with missing lines Patch % Lines
src/libfuncs/bounded_int.rs 0.00% 11 Missing ⚠️
src/libfuncs/box.rs 0.00% 9 Missing ⚠️
src/libfuncs.rs 91.04% 6 Missing ⚠️
src/libfuncs/starknet.rs 78.57% 3 Missing ⚠️
src/libfuncs/nullable.rs 93.33% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #919      +/-   ##
==========================================
+ Coverage   82.91%   83.00%   +0.08%     
==========================================
  Files         120      115       -5     
  Lines       34334    34103     -231     
==========================================
- Hits        28468    28307     -161     
+ Misses       5866     5796      -70

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 13, 2024 •
edited
Loading

Benchmark results Main vs HEAD.

Command Mean [s] Min [s] Max [s] Relative
head factorial_2M.cairo (JIT) 3.131 ± 0.022 3.096 3.164 1.00
base factorial_2M.cairo (JIT) 3.154 ± 0.019 3.121 3.180 1.01 ± 0.01
head factorial_2M.cairo (AOT) 3.318 ± 0.022 3.298 3.368 1.06 ± 0.01
base factorial_2M.cairo (AOT) 3.338 ± 0.015 3.315 3.357 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head fib_2M.cairo (JIT) 2.674 ± 0.021 2.639 2.699 1.00
base fib_2M.cairo (JIT) 2.684 ± 0.026 2.650 2.723 1.00 ± 0.01
head fib_2M.cairo (AOT) 2.844 ± 0.013 2.826 2.861 1.06 ± 0.01
base fib_2M.cairo (AOT) 2.870 ± 0.017 2.850 2.910 1.07 ± 0.01
Command Mean [s] Min [s] Max [s] Relative
head logistic_map.cairo (JIT) 2.979 ± 0.033 2.932 3.048 1.00 ± 0.01
base logistic_map.cairo (JIT) 2.976 ± 0.023 2.941 3.015 1.00
head logistic_map.cairo (AOT) 3.026 ± 0.027 3.001 3.093 1.02 ± 0.01
base logistic_map.cairo (AOT) 3.038 ± 0.018 3.007 3.068 1.02 ± 0.01

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JulianGCalderon JulianGCalderon JulianGCalderon left review comments

@edg-l edg-l edg-l approved these changes

@igaray igaray Awaiting requested review from igaray igaray is a code owner

@jrchatruc jrchatruc Awaiting requested review from jrchatruc jrchatruc is a code owner

@entropidelic entropidelic Awaiting requested review from entropidelic entropidelic is a code owner

@fmoletta fmoletta Awaiting requested review from fmoletta fmoletta is a code owner

@Oppen Oppen Awaiting requested review from Oppen Oppen is a code owner

@pefontana pefontana Awaiting requested review from pefontana pefontana is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make the no-op libfuncs cleaner
4 participants
@azteca1998 @codecov-commenter @edg-l @JulianGCalderon