Refactor get_current_version_from_game_mode/1 function

lambdaclass · Aug 14, 2024 · 77c5b01 · 77c5b01
1 parent cdbbc7d
commit 77c5b01
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/apps/game_backend/lib/game_backend/configuration.ex b/apps/game_backend/lib/game_backend/configuration.ex
@@ -402,7 +402,8 @@ defmodule GameBackend.Configuration do
   def get_current_version_from_game_mode(game_mode) do
     q =
       from(v in Version,
-        where: v.current and v.game_mode_id == ^game_mode.id,
+        join: g in assoc(v, :game_mode),
+        where: v.current and g.name == ^game_mode,
         preload: [
           :consumable_items,
           :skills,

diff --git a/apps/gateway/lib/gateway/controllers/curse_of_mirra/configuration_controller.ex b/apps/gateway/lib/gateway/controllers/curse_of_mirra/configuration_controller.ex
@@ -8,7 +8,6 @@ defmodule Gateway.Controllers.CurseOfMirra.ConfigurationController do
   action_fallback Gateway.Controllers.FallbackController
 
   def get_game_mode_configuration(conn, %{"game_mode" => game_mode}) do
-    game_mode = Configuration.get_game_mode_by_name(game_mode)
     version = Configuration.get_current_version_from_game_mode(game_mode)
 
     config =