PHP 8.1 support #94
Closed
PHP 8.1 support #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
froschdesign
requested changes
Feb 24, 2022
Signed-off-by: kristijonas bulzgis <[email protected]>
Co-authored-by: Piotr Zygmuntowicz <[email protected]> Signed-off-by: kristijonas bulzgis <[email protected]>
Signed-off-by: kristijonas bulzgis <[email protected]>
Signed-off-by: kristijonas bulzgis <[email protected]>
Co-authored-by: Frank Brückner <[email protected]> Signed-off-by: kristijonas bulzgis <[email protected]>
Ocramius
requested changes
Feb 24, 2022
|
So, for PHP 8.1, the current obstacles are upgrades of these modules:
Also, I suggest dropping support for PHP 7.3, and avoid committing composer.lock to the repository (composer.lock can be generated automatically during the CI run). |
We will commit We are currently adding @renovatebot to all our repos to keep it fresh on a daily basis, and eagerly discover incompatibilities. Totally okay with dropping php 7.3: we don't support EOL php versions anyway |
Signed-off-by: kristijonas bulzgis <[email protected]>
Ocramius
requested changes
Feb 24, 2022
Signed-off-by: kristijonas bulzgis <[email protected]>
Open
|
Moved to #95 meanwhile, thanks for all your help though, still adding this to release notes for accrediting it :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PHP 8.1 support