Drop PHP 7, add PHP 8.2 Support #96
Conversation
|
Needs laminas-api-tools/api-tools-api-problem to be upgraded (laminas-api-tools/api-tools-api-problem#24) |
composer.json
Outdated
| @@ -29,7 +29,7 @@ | |||
| } | |||
| }, | |||
| "require": { | |||
| "php": "^7.3 || ~8.0.0 || ~8.1.0", | |||
| "php": "^7.3 || ~8.0.0 || ~8.1.0 || ~8.2.0", | |||
There was a problem hiding this comment.
Needs composer.lock update too - possibly good idea to drop PHP 7 to simplify the matrix
Signed-off-by: Roger Vilà <[email protected]>
Signed-off-by: Roger Vilà <[email protected]>
rogervila
force-pushed
the
php-82-support
branch
from
301d7bb
to
9a5d236
Compare
|
Needs |
src/DbConnectedResource.php
Outdated
| @@ -97,6 +98,7 @@ public function fetch($id) | |||
| if (0 === $resultSet->count()) { | |||
| throw new DomainException('Item not found', 404); | |||
| } | |||
| /** @psalm-var array|object */ | |||
There was a problem hiding this comment.
Same here: let's leave the baseline larger here, rather than providing inline hints
src/DbConnectedResource.php
Outdated
| @@ -128,6 +130,7 @@ protected function retrieveData($data) | |||
| return $filter->getValues(); | |||
| } | |||
|
|
|||
| /** @psalm-var array<string, mixed> */ | |||
There was a problem hiding this comment.
Isn't getValues() already in this shape? 🤔
There was a problem hiding this comment.
It is. I've removed the hint, though this means stuffing something into the baseline. But Psalm should have been able to infer this.
test/ApplicationTest.php
Outdated
| @@ -22,6 +23,12 @@ class ApplicationTest extends TestCase | |||
| { | |||
| use ProphecyTrait; | |||
|
|
|||
| /** @var ContainerInterface|ObjectProphecy */ | |||
There was a problem hiding this comment.
We can use native types in here, if needed, otherwise all good, so this is just a nit
Bumps to versions known to test against 8.2. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Turns out, there's no need anyways. Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Per @Ocramius Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Per @Ocramius Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
Currently blocked by laminas-api-tools/api-tools-content-validation#22; turning to that next. |
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
Now blocked by api-tools-mvc-auth, turning to that. |
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Signed-off-by: Matthew Weier O'Phinney <[email protected]>
- Bumps rpc to 1.8 - Bumps servicemanager to 3.11+ - Drops laminas-zendframework-bridge Signed-off-by: Matthew Weier O'Phinney <[email protected]>
Picks up PHP 8.2 support Signed-off-by: Matthew Weier O'Phinney <[email protected]>
|
Ready for final review! |
Description
Support PHP 8.2