Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PHP 8.3 support for sqlsrv extension #211

Merged
merged 2 commits into from
Feb 1, 2024

Conversation

MauricioFauth
Copy link
Contributor

Q A
Documentation no
Bugfix no
BC Break no
New Feature yes
RFC no
QA no

Description

As this is a beta release, it should not be used for PHP 8.1 and 8.2.

https://github.com/microsoft/msphpsql/releases/tag/v5.12.0-beta1

@Xerkus
Copy link
Member

Xerkus commented Jan 31, 2024

I think sqlsrv release archives should be updated to use ubuntu22 variant to match ci container.

@boesing
Copy link
Member

boesing commented Jan 31, 2024

are these available? then id say yes. I wonder if there is a way to have that Ubuntu version get parsed to not have to manually update a bunch of files.

@Xerkus
Copy link
Member

Xerkus commented Jan 31, 2024

are these available? then id say yes. I wonder if there is a way to have that Ubuntu version get parsed to not have to manually update a bunch of files.

It is highly dependent on what files are uploaded to sqlsrv github release. No need for special parsing imo.

MauricioFauth and others added 2 commits January 31, 2024 22:56
As this is a beta release, it should not be used for PHP 8.1 and 8.2.

Signed-off-by: Maurício Meneghini Fauth <[email protected]>
@Xerkus
Copy link
Member

Xerkus commented Jan 31, 2024

Can someone verify extension actually works on 8.3?

@Xerkus Xerkus merged commit 8818806 into laminas:1.38.x Feb 1, 2024
3 checks passed
@Xerkus
Copy link
Member

Xerkus commented Feb 1, 2024

@MauricioFauth thank you

@MauricioFauth MauricioFauth deleted the sqlsrv-83 branch February 1, 2024 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlsrv for PHP 8.3
3 participants